On Tue, Sep 16, 2025 at 04:11:53PM -0600, Uday Shankar wrote: > Some ublk selftests have strange behavior when fio is not installed. > While most tests behave correctly (run if they don't need fio, or skip > if they need fio), the following tests have different behavior: > > - test_null_01 and test_null_02 try to run fio without checking if it > exists first, and fail on any failure of the fio command (including > "fio command not found"). So these tests fail when they should skip. > - test_stress_05 runs fio without checking if it exists first, but > doesn't fail on fio command failure. This test passes, but that pass > is misleading as the test doesn't do anything useful without fio > installed. So this test passes when it should skip. > > Fix these issues by adding _have_program fio checks to the top of all > three of these tests. > > Signed-off-by: Uday Shankar <ushan...@purestorage.com>
Please disregard; it was pointed out to me that I missed a few tests. Will post an updated v2 soon.