On Thu, Nov 06, 2025 at 07:55:33PM -0800, Eric Biggers wrote: > On Fri, Oct 31, 2025 at 10:34:34AM +0100, Christoph Hellwig wrote: > > While the pblk argument to fscrypt_zeroout_range_inline_crypt is > > declared as a sector_t it actually is interpreted as a logical block > > size unit, which is highly unusual. Switch to passing the 512 byte > > units that sector_t is defined for. > > > > Signed-off-by: Christoph Hellwig <[email protected]> > > --- > > fs/crypto/bio.c | 9 ++++----- > > 1 file changed, 4 insertions(+), 5 deletions(-) > > Looks fine, though of course fscrypt_zeroout_range() itself still takes > a 'sector_t pblk' argument.
Yes. The argument conventions for fscrypt are a bit odd in general. I actually cleaned all this up for an earlier version, but decided to keep it minimal for this version: https://git.infradead.org/?p=users/hch/misc.git;a=shortlog;h=refs/heads/fscrypt-experiments I plan to bring the ext4/fscrypt cleanups in that branch back later.
