On Sat, Nov 29, 2025 at 3:48 AM Stephen Zhang <[email protected]> wrote: > zhangshida <[email protected]> 于2025年11月28日周五 16:33写道： > > > > From: Shida Zhang <[email protected]> > > > > Replace duplicate bio chaining logic with the common > > bio_chain_and_submit helper function. > > > > Signed-off-by: Shida Zhang <[email protected]> > > --- > > fs/gfs2/lops.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c > > index 9c8c305a75c..0073fd7c454 100644 > > --- a/fs/gfs2/lops.c > > +++ b/fs/gfs2/lops.c > > @@ -487,8 +487,7 @@ static struct bio *gfs2_chain_bio(struct bio *prev, > > unsigned int nr_iovecs) > > new = bio_alloc(prev->bi_bdev, nr_iovecs, prev->bi_opf, GFP_NOIO); > > bio_clone_blkg_association(new, prev); > > new->bi_iter.bi_sector = bio_end_sector(prev); > > - bio_chain(new, prev); > > - submit_bio(prev); > > + bio_chain_and_submit(prev, new); > > This one should also be dropped because the 'prev' and 'new' are in > the wrong order.
Ouch. Thanks for pointing this out. > Thanks, > Shida > > > return new; > > } > > > > -- > > 2.34.1 > > > Andreas
