Hi Christoph, kernel test robot noticed the following build errors:
[auto build test ERROR on axboe/for-next] [also build test ERROR on jaegeuk-f2fs/dev-test jaegeuk-f2fs/dev linus/master next-20251211] [cannot apply to tytso-ext4/dev brauner-vfs/vfs.all v6.18] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Christoph-Hellwig/fscrypt-keep-multiple-bios-in-flight-in-fscrypt_zeroout_range_inline_crypt/20251211-002354 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux.git for-next patch link: https://lore.kernel.org/r/20251210152343.3666103-9-hch%40lst.de patch subject: [PATCH 8/9] blk-crypto: optimize data unit alignment checking config: nios2-allnoconfig (https://download.01.org/0day-ci/archive/20251211/[email protected]/config) compiler: nios2-linux-gcc (GCC) 11.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251211/[email protected]/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <[email protected]> | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ All errors (new ones prefixed by >>): block/blk-merge.c: In function 'bio_split_io_at': >> block/blk-merge.c:332:47: error: 'struct bio' has no member named >> 'bi_crypt_context' 332 | struct bio_crypt_ctx *bc = bio->bi_crypt_context; | ^~ vim +332 block/blk-merge.c 310 311 /** 312 * bio_split_io_at - check if and where to split a bio 313 * @bio: [in] bio to be split 314 * @lim: [in] queue limits to split based on 315 * @segs: [out] number of segments in the bio with the first half of the sectors 316 * @max_bytes: [in] maximum number of bytes per bio 317 * 318 * Find out if @bio needs to be split to fit the queue limits in @lim and a 319 * maximum size of @max_bytes. Returns a negative error number if @bio can't be 320 * split, 0 if the bio doesn't have to be split, or a positive sector offset if 321 * @bio needs to be split. 322 */ 323 int bio_split_io_at(struct bio *bio, const struct queue_limits *lim, 324 unsigned *segs, unsigned max_bytes) 325 { 326 struct bio_vec bv, bvprv, *bvprvp = NULL; 327 unsigned nsegs = 0, bytes = 0, gaps = 0; 328 struct bvec_iter iter; 329 unsigned len_align_mask = lim->dma_alignment; 330 331 if (bio_has_crypt_ctx(bio)) { > 332 struct bio_crypt_ctx *bc = bio->bi_crypt_context; 333 334 len_align_mask |= (bc->bc_key->crypto_cfg.data_unit_size - 1); 335 } 336 337 bio_for_each_bvec(bv, bio, iter) { 338 if (bv.bv_offset & len_align_mask) 339 return -EINVAL; 340 341 /* 342 * If the queue doesn't support SG gaps and adding this 343 * offset would create a gap, disallow it. 344 */ 345 if (bvprvp) { 346 if (bvec_gap_to_prev(lim, bvprvp, bv.bv_offset)) 347 goto split; 348 gaps |= bvec_seg_gap(bvprvp, &bv); 349 } 350 351 if (nsegs < lim->max_segments && 352 bytes + bv.bv_len <= max_bytes && 353 bv.bv_offset + bv.bv_len <= lim->max_fast_segment_size) { 354 nsegs++; 355 bytes += bv.bv_len; 356 } else { 357 if (bvec_split_segs(lim, &bv, &nsegs, &bytes, 358 lim->max_segments, max_bytes)) 359 goto split; 360 } 361 362 bvprv = bv; 363 bvprvp = &bvprv; 364 } 365 366 *segs = nsegs; 367 bio->bi_bvec_gap_bit = ffs(gaps); 368 return 0; 369 split: 370 if (bio->bi_opf & REQ_ATOMIC) 371 return -EINVAL; 372 373 /* 374 * We can't sanely support splitting for a REQ_NOWAIT bio. End it 375 * with EAGAIN if splitting is required and return an error pointer. 376 */ 377 if (bio->bi_opf & REQ_NOWAIT) 378 return -EAGAIN; 379 380 *segs = nsegs; 381 382 /* 383 * Individual bvecs might not be logical block aligned. Round down the 384 * split size so that each bio is properly block size aligned, even if 385 * we do not use the full hardware limits. 386 * 387 * It is possible to submit a bio that can't be split into a valid io: 388 * there may either be too many discontiguous vectors for the max 389 * segments limit, or contain virtual boundary gaps without having a 390 * valid block sized split. A zero byte result means one of those 391 * conditions occured. 392 */ 393 bytes = ALIGN_DOWN(bytes, bio_split_alignment(bio, lim)); 394 if (!bytes) 395 return -EINVAL; 396 397 /* 398 * Bio splitting may cause subtle trouble such as hang when doing sync 399 * iopoll in direct IO routine. Given performance gain of iopoll for 400 * big IO can be trival, disable iopoll when split needed. 401 */ 402 bio_clear_polled(bio); 403 bio->bi_bvec_gap_bit = ffs(gaps); 404 return bytes >> SECTOR_SHIFT; 405 } 406 EXPORT_SYMBOL_GPL(bio_split_io_at); 407 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
