On Thu, Dec 21 2006, Ming Zhang wrote: > On Thu, 2006-12-21 at 15:55 +0100, Jens Axboe wrote: > > On Thu, Dec 21 2006, Ming Zhang wrote: > > > current code will show_stats() even when do_foo() return non zero. > > > > Applied. do_file() never returns an error, this might be another area > > for improvement. > > > > yes, i am adding the naming check so probably will return a EINVAL soon.
Great > and many places do not check the return value of malloc or strdup. Honestly, I never bother with that for non-critical user space things. Linux will basically never fail a malloc or strdup unless overcommit is turned off, which is not the default. So not much point complicating the code with error handling for that. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-btrace" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
