On Wed, Jan 28, 2009 at 12:08:29PM +0800, Yan Zheng wrote: > 2009/1/28 Josef Bacik <[email protected]>: > > Hello, > > > > Theres a slight problem with finish_current_insert, if we set all to 1 and > > then > > go through and don't actually skip any of the extents on the pending list, > > we > > could exit right after we've added new extents. This is a problem because > > by > > inserting the new extents we could have gotten new COW's to happen and > > such, so > > we may have some pending updates to do or even more inserts to do after > > that. > > So this patch will only exit if we have never skipped any of the extents in > > the > > pending list, and we have no extents to insert, this will make sure that > > all of > > the pending work is truly done before we return. I've been running with > > this > > patch for a few days with all of my other testing and have not seen issues. > > Thanks, > > Hi > > I think this patch doesn't handle the case we only find some pending updates > ,but neither find any pending insertion nor skip any extent on the pending > list. > In that case, num_inserts == 0, restart == 0. finish_current_insert > exits immediately > after update_backrefs return. This problem is that update_backrefs may add > new extents to the pending list. >
Hmm crap it can can't it. Alright I will fix that, thanks, Josef -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
