move the ACL validation check in to fs/posix_acl.c. Including nullpointer check and PTR_ERR check.
--- Signed-off-by: Liuwenyi <qingshen...@gmail.com> Cc: Chris Mason <chris.ma...@oracle.com> Cc: Al Viro <v...@zeniv.linux.org.uk> Cc: Joel Becker <joel.bec...@oracle.com> Cc: Chris Ball <c...@laptop.org> Cc: James Morris <jmor...@namei.org> Cc: linux-btrfs@vger.kernel.org Cc: linux-ker...@vger.kernel.org --- diff --git a/fs/btrfs/acl.c b/fs/btrfs/acl.c index 2e9e699..0f14f95 100644 --- a/fs/btrfs/acl.c +++ b/fs/btrfs/acl.c @@ -102,12 +102,9 @@ static int btrfs_set_acl(struct btrfs_trans_handle *trans, char *value = NULL; mode_t mode; - if (acl) { - ret = posix_acl_valid(acl); - if (ret < 0) - return ret; - ret = 0; - } + ret = posix_acl_valid(acl); + if (ret < 0) + return ret; switch (type) { case ACL_TYPE_ACCESS: -- Best Regards, Liuwenyi -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html