Hi Chris, What is the motivation behind the two phases of snapshot creation (create_pending_snapshot, finish_pending_snapshot)? Is it just to avoid putting a reference to the snap subvol inside the snapped version of the subvol (forming a loop)?
If that's the case, I think the problem can be solved in other ways (by not following the subvol link if it loops to self, or by also delaying the root creation to avoid leaking an unreferenced root). And the rest of the time (when the link is outside the linked-to subvol) committing the root and it's reference in one commit. Unless I'm missing something else? Thanks- sage -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
