On Thu, Jul 29, 2010 at 11:15:57PM +0400, Vasiliy Kulikov wrote: > Hi, > > I've discovered that some btrfs code doesn't check whether kmalloc() > call succeeded. I poorly understand what this code does and how it can > be changed, maybe it would be happy with __GFP_NOFAIL. > > Also there are BUG_ON() after kmalloc()'s, if they could be changed not > to panic it would be great. > >
Yeah. That doesn't seem right. I have pushed a change to smatch to find places like that. It's valid to call BUG_ON() for allocation failures during init so the check is disabled by default. Use the --spammy option to enable it. dcarpen...@bicker:~/progs/kernel/devel$ kchecker --spammy fs/btrfs/tree-log.c CHK include/linux/version.h CHK include/generated/utsrelease.h CALL scripts/checksyscalls.sh CHECK fs/btrfs/tree-log.c fs/btrfs/tree-log.c +823 add_inode_ref(43) warn: bug on allocation failure 'name' fs/btrfs/tree-log.c +868 add_inode_ref(88) warn: bug on allocation failure 'victim_name' fs/btrfs/tree-log.c +3123 btrfs_recover_log_trees(58) error: 'wc.replay_dest' dereferencing possible ERR_PTR() CC [M] fs/btrfs/tree-log.o dcarpen...@bicker:~/progs/kernel/devel$ regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
