On Monday, 29 November, 2010, Goffredo Baroncelli wrote: > Why the unused fields ? What happens if you use a more recent btrfs-tools > which take advantage of these fields but the kernel is an old one ? At the > minimum please check the flags so > (flags^(BTRFS_SNAPSHOT_CREATE_ASYNC|BTRFS_SNAPSHOT_RDONLY)) == 0 > and > unused[0..3] == 0
Sorry, the check should be (flags & (~(BTRFS_SNAPSHOT_CREATE_ASYNC|BTRFS_SNAPSHOT_RDONLY))) == 0 > > For future expansion I suggest to use a different ioctl. To me it seems a more > robust API. > -- gpg key@ keyserver.linux.it: Goffredo Baroncelli (ghigo) <kreij...@inwind.it> Key fingerprint = 4769 7E51 5293 D36C 814E C054 BF04 F161 3DC5 0512 -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
