On Fri, Dec 03, 2010 at 04:01:44PM -0700, Andreas Dilger wrote: > On 2010-12-03, at 15:45, J. Bruce Fields wrote: > > We're using statfs64.fs_fsid for this; I believe that's both stable > > across reboots and distinguishes between subvolumes, so that's OK. > > > > (That said, since fs_fsid doesn't work for other filesystems, we depend > > on an explicit check for a filesystem type of "btrfs", which is > > awful--btrfs won't always be the only filesystem that wants to do this > > kind of thing, etc.) > > Sigh, I wanted to be able to specify the NFS FSID directly from within the > kernel for Lustre many years already. Glad to see that this is moving > forward. > > Any chance we can add a ->get_fsid(sb, inode) method to export_operations > (or something simiar), that allows the filesystem to generate an FSID based > on the volume and inode that is being exported?
No objection from here. (Though I don't understand the inode argument--aren't "subvolumes" usually expected to have separate superblocks?) --b. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
