On 02/07/2011 01:22 PM, Eduardo Silva wrote: > Please find the attached patch which replace unsafe strcpy(3) by > strncpy(3) functions. > > regards, > > Eduardo Silva
Hi Eduardo, even though some "strncpy" are unneeded because a check is performed before, I fully agree that "strncpy" is better than a simple strcpy. However I have to highlight that truncating a path without noticing may be lead to a problem (think a delete operation applied to a shorter path...). So can I ask you to add some checks to your patch, in order to warn the user that the path is too long ? Regards G.Baroncelli -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
