On 22.03.2011 17:38, David Sterba wrote: >> David Sterba wrote: >>> On Fri, Mar 11, 2011 at 03:49:40PM +0100, Arne Jansen wrote: >>>> This is the main scrub code. >>>> >>> >>> sizeof(struct scrub_dev) == 18760 on an x86_64, an order 3 allocation in >>> scrub_setup_dev() >> >> Is this a problem? There are only few allocations of it, one per device. > > High order allocations may fail when memory is fragmented, and should be > avoided when possible. (And it is here, allocate each 'struct scrub_bio' > separately and fill the bios array with pointers.) Scrub ioctl may fail > to start until order-3 allocation will be available. >
I updated this in my git repo. Thanks, Arne -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
