On Mon, Feb 06, 2012 at 07:18:24AM -0500, Christoph Hellwig wrote: > On Mon, Feb 06, 2012 at 12:53:21PM +0100, David Sterba wrote: > > On Sun, Feb 05, 2012 at 12:30:42PM +0200, Nikos Voutsinas wrote: > > > It's quite old, but what was this about; > > > > > > http://thread.gmane.org/gmane.comp.file-systems.btrfs/4487 > > > > Thanks, the patch looks ok and works as expected. > > > > Goffredo, do you want to resend it? (The lock around the mnt_root is not > > necessary.) I think it's a -rc material, more people came to ask about > > this on irc channel lately, we don't need to wait a full release cycle > > to merge this fix. > > No, it doesn't look good. Please do not introduce anything touching > non-superblock fields in ->show_options, thanks.
Umm... seq_dentry() on root dentry (which is what's getting passed to ->show_options() now) would be OK; this kind of playing with ->d_name is not. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
