On Thu, May 03, 2012 at 04:12:21PM -0700, Mark Fasheh wrote: > > > + > > > + ref_ptr = btrfs_item_ptr_offset(eb, slot); > > > + > > > + /* So that we don't loop back looking for old style log refs. */ > > > + ref_end = ref_ptr; > > > + > > > + extref = (struct btrfs_inode_extref *) > > > btrfs_item_ptr_offset(eb, slot); > > > + namelen = btrfs_inode_extref_name_len(eb, extref); > > > + name = kmalloc(namelen, GFP_NOFS); > > > > kmalloc may fail. > > Fixed both instances of this. I'm just testing for null return from kmalloc > and bubbling the -ENOMEM back up. The callers of add_inode_ref() will wind > up BUGing on us anyway but that's beyond the scope of this patch.
Yes, this is consistent with the rest of no-mem handling. Fixing all caller paths is not always trivial and one does not want to do it during a patch development. david -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
