Hi Stefan, when I checked your patch I found further problems to the function parse_size(): - this function is declared two time: both in mkfs.c and in cmd-filesystem.c; this is a good chance to move it in the utils.c file. - your suggestion was to use atoll, which is signed. strtoull (which is unsigned) would be a better choice. - this function doesn't check for overflow [minor] - if a number like 123MB is passed, it is evaluated as 123 instead of 123*1024*1024 [bug]
This suggested me to make the following patch. Hoping to not offende anybody :-) BR G.Baroncelli Signed-off-by: Goffredo Baroncelli <[email protected]> You can pull the patch from http://cassiopea.homelinux.net/git/btrfs-progs-unstable.git branch parse_size -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
