On Tue, Oct 16, 2012 at 10:00 PM, Fengguang Wu <[email protected]> wrote: > On Wed, Oct 17, 2012 at 12:28:05AM +0530, [email protected] wrote: >> From: Raghavendra D Prabhu <[email protected]> >> >> >From 51daa88ebd8e0d437289f589af29d4b39379ea76, page_sync_readahead coalesces >> async readahead into its readahead window, so another checking for that >> again is >> not required. >> >> Signed-off-by: Raghavendra D Prabhu <[email protected]> >> --- >> fs/btrfs/relocation.c | 10 ++++------ >> mm/filemap.c | 3 +-- >> 2 files changed, 5 insertions(+), 8 deletions(-) >> >> diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c >> index 4da0865..6362003 100644 > >> --- a/fs/btrfs/relocation.c >> +++ b/fs/btrfs/relocation.c >> @@ -2996,12 +2996,10 @@ static int relocate_file_extent_cluster(struct inode >> *inode, >> ret = -ENOMEM; >> goto out; >> } >> - } >> - >> - if (PageReadahead(page)) { >> - page_cache_async_readahead(inode->i_mapping, >> - ra, NULL, page, index, >> - last_index + 1 - index); >> + } else if (PageReadahead(page)) { >> + page_cache_async_readahead(inode->i_mapping, >> + ra, NULL, page, index, >> + last_index + 1 - >> index); > > That extra indent is not necessary. > > Otherwise looks good to me. Thanks! > > Reviewed-by: Fengguang Wu <[email protected]>
Hi Raghavendra, Indentation breakage is now welcome. Please respin it. Otherwise Acked-by: KOSAKI Motohiro <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
