On fri, 14 Dec 2012 12:51:06 -0500, Josef Bacik wrote:
> On Mon, Nov 26, 2012 at 02:28:13AM -0700, Miao Xie wrote:
>> If we remount the fs to close the auto defragment or make the fs R/O, we
>> should
>> stop the auto defragment.
>>
>> Signed-off-by: Miao Xie <[email protected]>
>
> I'm dropping this patch, it causes a deadlock since defrag will need to
> reserve
> metadata which could call writeback_sb_nr_if_idle which does a
> down_read(&sb->s_umount). Figure out another way to fix this and I'll apply
> it.
> Thanks,
Hi, Josef
I forget to point out this patch is based on my patches:
[PATCH 1/2 RESEND] vfs: re-implement writeback_inodes_sb(_nr)_if_idle()
and rename them
[PATCH 2/2 RESEND] Btrfs: flush all the dirty pages if
try_to_writeback_inodes_sb_nr() fails
But I found you implemented a new writeback_sb_nr_if_idle()(Btrfs: fix
autodefrag and umount lockup),
with this new function, my patch(Btrfs: fix remount vs autodefrag) also can
wrok well.
Thanks
Miao
>
> Josef
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
