Hi Miao, On 28.01.2013 13:44, Miao Xie wrote: > On mon, 28 Jan 2013 13:03:46 +0100, Jan Schmidt wrote: >> When start_transaction() returns ENOSPC after btrfs_qgroup_reserve(), we >> must call btrfs_qgroup_free() to avoid the qgroup counters increasing when >> there's actually no data being written. >> >> Signed-off-by: Jan Schmidt <[email protected]> >> --- >> Josef: It looks like these places (except the first) are candidates for >> btrfs_block_rsv_release, please check. > > I didn't note that you have made a patch for the qgroup reservation problem, > so I sent > my fix patch. > > But start_transaction() has reservation problems not only for qgroup, but > also for > the free space, your patch didn't fix the free space reservation problem.
I see, we better take your patch then. Although my commit message was way more descriptive ;-) Josef: You've been saved. Thanks, -Jan -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
