On Fri, Apr 12, 2013 at 09:44:53AM +0200, Stefan Behrens wrote: > On Fri, 12 Apr 2013 08:58:27 +0800, Wang Shilong wrote: > >> "btrfs subvolume list" gets a new option "--fields=..." which allows > >> to specify which pieces of information about subvolumes shall be > >> printed. This is necessary because this commit also adds all the so > >> far missing items from the root_item like the received UUID, all > >> generation values and all time values. > >> > >> The parameters to the "--fields" option is a list of items to print: > >> --fields=gen,dirid,uuid,puuid,ruuid,cgen,ogen,sgen,rgen,ctime,otime, > >> stime,rtime,path,rootid,parent,topid,all > > > > The new option '--fields' is helpful, however, i am wondering > > whether we should remove the old options '-g', '-c'...etc. These > > options has been there for a period of time,some shell script may use > > it. > > > > IMO, to ensure compatibility, we'd better keep it. > > What do other people on the list think about maintaining compatibility > in this case? > > IMO it is acceptable to break compatibility for such a change. It would > confuse everybody who reads the man page that there are 1 1/2 ways to > configure the printed columns.
Counting those in your patch, there are currently 17 fields to print, I think that it's impossible to keep sane assignment of single letters to each field. I'm for dropping them at the cost of breaking some scripts and introduce a predefined sets of fields to print based on most common usages. For example send/recv related, or a very short output with just id,path etc. For some period we should add a deprecation warning for the removed options so it's not completely silent change. david -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
