On Wed, July 03, 2013 at 08:40 (+0200), Liu Bo wrote:
> commit 47fb091fb787420cd195e66f162737401cce023f(Btrfs: fix unlock after free 
> on rewinded tree blocks)
> takes an extra increment on the reference of allocated dummy extent buffer, 
> so now we
> cannot free this dummy one, and end up with extent buffer leak.
> 
> Signed-off-by: Liu Bo <bo.li....@oracle.com>

Reviewed-by: Jan Schmidt <list.bt...@jan-o-sch.net>

> ---
>  fs/btrfs/ctree.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
> index 02fae7f..3d790b4 100644
> --- a/fs/btrfs/ctree.c
> +++ b/fs/btrfs/ctree.c
> @@ -1268,12 +1268,12 @@ tree_mod_log_rewind(struct btrfs_fs_info *fs_info, 
> struct extent_buffer *eb,
>               BUG_ON(!eb_rewin);
>       }
>  
> -     extent_buffer_get(eb_rewin);
>       btrfs_tree_read_unlock(eb);
>       free_extent_buffer(eb);
>  
>       extent_buffer_get(eb_rewin);
>       btrfs_tree_read_lock(eb_rewin);
> +
>       __tree_mod_log_rewind(eb_rewin, time_seq, tm);
>       WARN_ON(btrfs_header_nritems(eb_rewin) >
>               BTRFS_NODEPTRS_PER_BLOCK(fs_info->tree_root));
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to