Quoting Martin (2013-11-22 04:03:41) > On 21/11/13 23:37, Chris Mason wrote: > > Quoting Martin (2013-11-08 18:53:06) > >> On 08/11/13 22:01, Chris Mason wrote: > >>> Hi everyone, > >>> > >>> This patch is now the tip of the master branch for btrfs-progs, which > >>> has been updated to include most of the backlogged progs patches. > >>> Please take a look and give it a shake. This was based on Dave's > >>> integration tree (many thanks Dave!) minus the patches for online dedup. > >>> I've pulled in the coverity fixes and a few others from the list as > >>> well. > >>> > >>> The patch below switches our default mkfs leafsize up to 16K. This > >>> should be a better choice in almost every workload, but now is your > >>> chance to complain if it causes trouble. > >> > >> Thanks for that and nicely timely! > >> > >> Compiling on Gentoo (3.11.5-gentoo, sys-fs/btrfs-progs-9999) gives: > >> > >> > >> * QA Notice: Package triggers severe warnings which indicate that it > >> * may exhibit random runtime failures. > >> * disk-io.c:91:5: warning: dereferencing type-punned pointer will break > >> strict-aliasing rules [-Wstrict-aliasing] > >> * volumes.c:1930:5: warning: dereferencing type-punned pointer will > >> break strict-aliasing rules [-Wstrict-aliasing] > >> * volumes.c:1931:6: warning: dereferencing type-punned pointer will > >> break strict-aliasing rules [-Wstrict-aliasing] > > > > I'm not seeing these warnings with the current master branch, could you > > please rerun? > > From just now: > > > * QA Notice: Package triggers severe warnings which indicate that it > * may exhibit random runtime failures. > * disk-io.c:91:5: warning: dereferencing type-punned pointer will break > strict-aliasing rules [-Wstrict-aliasing] > * volumes.c:1930:5: warning: dereferencing type-punned pointer will > break strict-aliasing rules [-Wstrict-aliasing] > * volumes.c:1931:6: warning: dereferencing type-punned pointer will > break strict-aliasing rules [-Wstrict-aliasing]
Does gentoo modify the optimizations from the Makefile? We actually have many strict-aliasing warnings, but I didn't think they came up until -O2. At any rate, I'm adding -fno-strict-aliasing just to be sure. -chris -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
