On Fri, Dec 13, 2013 at 01:42:57PM +0800, Liu Bo wrote: > On Tue, Dec 03, 2013 at 07:13:48PM +0200, Alex Lyakas wrote: > > Hi Liu, Jan, > > > > What happens to "struct qgroup_update"s sitting in > > trans->qgroup_ref_list in case the transaction aborts? It seems that > > they are not freed. > > > > For example, if we are in btrfs_commit_transaction() and: > > - call create_pending_snapshots() > > - call btrfs_run_delayed_items() and this fails > > So we go to cleanup_transaction() without calling > > btrfs_delayed_refs_qgroup_accounting(), which would have been called > > by btrfs_run_delayed_refs(). > > > > I receive kmemleak warnings about these thingies not being freed, > > although on an older kernel. However, looking at Josef's tree, this > > still seems to be the case. > > I think you're right, but I'm sure because I cannot reproduce that somehow,
Sorry, s/'sure'/'not sure'/g -liubo -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
