On Tue, Feb 11, 2014 at 07:20:23PM +0100, Goffredo Baroncelli wrote: > On 02/11/2014 02:14 PM, Josef Bacik wrote: > > > > > > On 02/10/2014 05:26 PM, Goffredo Baroncelli wrote: > >> On 02/10/2014 05:41 PM, Josef Bacik wrote: > >>> ===== New and improved btrfs fi df ===== > [...] > > Hi Josef > > > The problem I had with this patch was it didn't give me a way to get > > the original output. I as a developer really need to have the raw > > dump of the block group info as I'm doing stuff. So I like this > > output, but I still need my old output, if you fix that part up I'll > > review/ack it. Thanks, > > I am open to improve this patch. What about the following output (it > was a copy and paste, no code for now, the number are invented) > > $ sudo btrfs filesystem df /mnt/btrfs1/ > Disk size: 400.00GB > Disk unallocated: 391.97GB > Disk allocation: > Allocated Used > Data, single: 2.01GB, 1.00GB > System, DUP: 4.00MB 2.00MB > System, single: 4.00MB 1.00MB > Metadata, DUP: 2.00GB 750.00MB > Metadata, single: 8.00MB 2.20MB > ------ ------- > Total: 7.00GB 1.75GB
Two minor nits here: please put a space between the number and the units, and distinguish between e.g. MB (powers of 10) and MiB (powers of 2). Hugo. -- === Hugo Mills: hugo@... carfax.org.uk | darksatanic.net | lug.org.uk === PGP key: 65E74AC0 from wwwkeys.eu.pgp.net or http://www.carfax.org.uk --- But somewhere along the line, it seems / That pimp became --- cool, and punk mainstream.
signature.asc
Description: Digital signature
