On Sat, 22 Feb 2014 01:23:37 +0100, David Sterba wrote: > On Thu, Feb 20, 2014 at 06:08:54PM +0800, Miao Xie wrote: >> @@ -1352,13 +1347,15 @@ static struct btrfs_root *alloc_log_tree(struct >> btrfs_trans_handle *trans, >> root->root_key.objectid = BTRFS_TREE_LOG_OBJECTID; >> root->root_key.type = BTRFS_ROOT_ITEM_KEY; >> root->root_key.offset = BTRFS_TREE_LOG_OBJECTID; >> + >> /* >> + * DON'T set REF_COWS for log trees >> + * >> * log trees do not get reference counted because they go away >> * before a real commit is actually done. They do store pointers >> * to file data extents, and those reference counts still get >> * updated (along with back refs to the log tree). >> */ >> - root->ref_cows = 0; > > This looks like a bugfix hidden in a cleanup patch. If it is standalone > and not related to changes in this patchset, it makes sense to send it > separately (and possibly CC stable).
It is a cleanup because we have set it to 0 before. I add this comment just to remind the other developer that don't set this flag. (The old one is not so striking, I think.) Thanks Miao -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
