On 04/04/2014 20:39, David Sterba wrote:
On Mon, Mar 31, 2014 at 10:13:56PM +0800, Anand Jain wrote:
From: Anand Jain <anand.j...@oracle.com>
This fix will ensure all SB copies on the disk is zeroed
when the disk is intentionally removed. This helps to
better manage disks in the user land.
Signed-off-by: Anand Jain <anand.j...@oracle.com>
btrfs: don't double brelse on device rm
Device removal currently causes bdev removal to try to double free a bh
in the bdev:
[ 55.714833] WARNING: at fs/buffer.c:1160 __brelse+0x36/0x40()
[ 55.714833] VFS: brelse: Trying to free free buffer
Commit 7e3d9ebb1 added a double release of the bh for a device being
removed when all the supers don't fit in the device. In that case it
releases the bh assuming that it's going to read a new one, finds that
it won't read, and goes to a label that releases the bh again.
All it needed to do was only brelse() right before overwriting the
current bh with __bread().
Signed-off-by: Zach Brown <z...@redhat.com>
This is a bit confusing, two changelogs, one patch, the referenced
commit id does not in fact exist. To keep all due credits, 2 patches
would make sense but ... up to you.
Sorry to know it was confusing. I have sent out V3 hope that's better.
-Anand
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
