On Thu, May 08, 2014 at 07:16:19PM -0400, Zach Brown wrote: > uncompress_inline() is silently dropping an error from > btrfs_decompress() after testing it and zeroing the page that was > supposed to hold decompressed data. This can silently turn compressed > inline data in to zeros if decompression fails due to corrupt compressed > data or memory allocation failure. > > I have no idea why uncompress_inline() is zeroing the page for an error > from btrfs_decompress() but not for the earlier ENOMEM from kmalloc(). > Can someone explain this?
I don't see a reason for that in the current code, nor in the code that introduced it. The changes that could have affected that are in the error handling, but even with that in mind, the silent error does not make sense. > Signed-off-by: Zach Brown <z...@redhat.com> Reviewed-by: David Sterba <dste...@suse.cz> And future ACK if you're going to kill the memset. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
