On Wed, May 07, 2014 at 01:07:14PM -0700, Mark Fasheh wrote: > The first two patches set up for qgroups: > > - The change in patch #1 is optional. It corrects the print of qgroup bytes > to be %llu as they are unsigned values. This means however that corrupted > groups will no longer show a negative value but instead an unrealistically > large one. It's my opinion that '-1' and '18446744073709551615' both look > pretty obviously broken when put in 'qgroup show' output so I'm going for > correctness. Here's the difference in output:
> 0/257 4109430784 -1429504 > 0/257 4109430784 18446744073708122112 Fair enough. > There's a minor issue in that we'll also print out qgroups for deleted > subvolumes as they still persist on disk (not shown here). I'm pretty sure > we can fix that with a followup patch to just check them against existing > subvolumes when we initially read our qgroup info from disk. I think the report from deleted subvols can help debugging, keep it there. We may decide to move it under its own option. Patches added to integration, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
