Hi,

As the subject specifies there is some confusion (at least with me:) as
to what should be the ouput/behaviour of command btrfs fi df

Please refer to https://bugzilla.redhat.com/show_bug.cgi?id=1114995

The comment by Eric Sendeen further complicates the understanding.
(again with me:)

1} The command btrfs fi df has been more or less been equated with
  traditional df. The problem is that traditional df does not output
  error when no path is given as what currently is done by btrfs fi df
2} Traditional df outputs a column 'Mounted on' for each device/fs it
  finds which btrfs fi df does not. For Ex.

  [vikram@localhost ~]# df
  Filesystem     1K-blocks      Used Available Use% Mounted on
  /dev/sdb6      153942744  69903440  81431312  47% /
  devtmpfs         1520392         0   1520392   0% /dev
  tmpfs            1527612      1444   1526168   1% /dev/shm
  tmpfs            1527612      9108   1518504   1% /run
  tmpfs            1527612         0   1527612   0% /sys/fs/cgroup
  tmpfs            1527612       120   1527492   1% /tmp
  /dev/sda1        1515376    172040   1248312  13% /boot
  /dev/dm-0      330327632 230022072  97561080  71% /home/vikram

  [vikram@localhost ~]# btrfs fi df /usr/
  Data, RAID1: total=42.00GiB, used=32.44GiB
  System, RAID1: total=32.00MiB, used=12.00KiB
  Metadata, RAID1: total=2.00GiB, used=915.04MiB

  [vikram@localhost ~]# btrfs fi df /
  Data, RAID1: total=42.00GiB, used=32.44GiB
  System, RAID1: total=32.00MiB, used=12.00KiB
  Metadata, RAID1: total=2.00GiB, used=915.04MiB

 [ivikram@localhost ~]# btrfs fi show
 Label: 'fedora'  uuid: d2b3420c-99c1-44cc-a922-ac266072c7fb
         Total devices 2 FS bytes used 33.33GiB
         devid    2 size 73.51GiB used 44.03GiB path /dev/sdb6
         devid    3 size 73.30GiB used 44.03GiB path /dev/sda2

 Label: 'Vikram'  uuid: 0809b072-35f3-4866-92b8-af4772b23ed6
         Total devices 2 FS bytes used 109.68GiB
         devid    1 size 158.03GiB used 157.00GiB path /dev/dm-0
         devid    2 size 157.00GiB used 157.00GiB path /dev/mapper/sdb1

So there in no way to understand if there was an error (except for non existant
path) in the path argument given to btrfs fi df. This can create a lot of
confusion in administeration.

So IMHO some changes need to done to btrfs fi df.

1} The requirement for path arg be removed, since that gives a false impression
  by a valid output that the arg was correct as in fs mount point sense POV.

2} btrfs fi df should output the mount point in all cases:
  a} Where arg path is valid but not a mount point. Should output btrfs FS info 
with mount point as traditional df.
  b} Where arg path is valid & is also a mount point. Should show output for 
that mount only.
  c} Where no arg is given, Should output all btrfs FSes info with mount points.

3} btrfs fi df should error out on an invalid path as it does currently.

Thanks for your precious time.

--
vikram...
        ||||||||
        ||||||||
^^'''''^^||root||^^^'''''''^^
       // \\   ))
      //(( \\// \\
     // /\\ ||   \\
    || / )) ((    \\
--
Nice boy, but about as sharp as a sack of wet mice.
                -- Foghorn Leghorn
--
 o
~|~
 =
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to