The btrfs-image tool should not be run on a mounted filesystem.
The undergoing fs operations may change what you have imaged a while ago,
this makes the image meanmingless.

Signed-off-by: Gui Hecheng <[email protected]>
---
 btrfs-image.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/btrfs-image.c b/btrfs-image.c
index 985aa26..9719d1c 100644
--- a/btrfs-image.c
+++ b/btrfs-image.c
@@ -2570,10 +2570,20 @@ int main(int argc, char *argv[])
                        num_threads = 1;
        }
 
-       if (create)
+       if (create) {
+               ret = check_mounted(source);
+               if (ret < 0) {
+                       fprintf(stderr, "Could not check mount status: %s\n",
+                       strerror(-ret));
+                       exit(1);
+               } else if (ret) {
+                       fprintf(stderr, "The device is busy\n");
+                       exit(1);
+               }
+
                ret = create_metadump(source, out, num_threads,
                                      compress_level, sanitize, walk_trees);
-       else
+       } else
                ret = restore_metadump(source, out, old_restore, 1,
                                       multi_devices);
        if (ret) {
-- 
1.8.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to