admin posted on Tue, 14 Oct 2014 13:17:41 +0200 as excerpted: >> And if you're affected, be aware that until we have a fix, we don't >> know if it'll be possible to remove the affected and currently >> undeletable snapshots. If it's not, at some point you'll need to do a >> fresh mkfs.btrfs, to get rid of the damage. Since the bug doesn't >> appear to affect writable snapshots or the "head" from which snapshots >> are made, it's not urgent, and a full fix is likely to include a patch >> to detect and fix the problem as well, but until we know what the >> problem is we can't be sure of that, so be prepared to do that mkfs at >> some point, as at this point it's possible that's the only way you'll >> be able to kill the corrupted snapshots. > > I don't agree with you concerning the not urgent part. In my opinion, > any problem leading to filesystem or other data corruption should be > considered as urgent, at least as long as it isn't known what exactly is > affected and whether there is a simple way to salvage the corruption > without going the backup/restore route.
I shouldn't have used a pronoun there as "it" wasn't clear. By "it", I didn't mean the bug, which I agree is urgent for the reasons you state, but the mkfs. Since there's currently no fix for the bug but it (the bug) seems to be limited to read-only snapshots at this point, _doing_the_mkfs_ isn't urgent. With the damage limited to the read-only snapshots, you don't have to drop everything and do a mkfs _right_now_ to be rid of it. But at some point, presumably after a fix is in place, since the damaged snapshots aren't currently always deletable, if the fix only prevents new damage from occurring and doesn't provide a way to fix the damaged ones, then mkfs would be the only way to do so. With the damage limited to those snapshots and not spreading to normal writable snapshots or the working copy, dropping everything to do that mkfs isn't urgent, but it (the mkfs) will need to be done at some point to clear the undeletable snapshots, again, assuming the fix doesn't provide a way to get rid of them (the currently undeletable snapshots). That's what I meant. Yes the bug is urgent. Doing a mkfs _right_now_ to get rid of the damage, not so much, because by all accounts so far the damage is limited to those read-only snapshots and isn't affecting ordinary writable snapshots or the working copies. -- Duncan - List replies preferred. No HTML msgs. "Every nonfree program has a lord, a master -- and if you use the program, he is your master." Richard Stallman -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html