On Fri, Mar 13, 2015 at 08:37:59AM +0800, Qu Wenruo wrote: > > On Thu, Mar 12, 2015 at 04:33:27PM +0800, Qu Wenruo wrote: > >> Use inline functions to do such things, to improve readability. > > > > This has actually hiden informations behind the helper function and > > old_refcnt and new_refcnt can explain themselves, I don't see any benefit. > Old/new_refcnt won't explain themselves.
I find the helpers useful, just please name them btrfs_qgroup_get_new_refcnt, btrfs_qgroup_get_old_refcnt etc. > In fact, it's a combination of sequence and reference number, which is > very confusing if you don't read qgroup_shared_accouting(). > > This patch will hides the confusing detail, caller will only need to > care the number to increase. > > Also, I'm considering split old/new_refcnt into seq and change them to > the delta to seq. > Current implement makes qgroup oper->seq completely meaningless. > Based on this patch, we only need some minor change to do this. Acked-by: David Sterba <[email protected]> I haven't really checked it's correct & working. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
