Hi,

On Thu, Aug 06, 2015 at 06:45:11PM +0900, ������ wrote:
> Hi, I made btrfs-progs android build script and test it.\

Thanks. The changes as they stand are too intrusive to be added but give
me an idea what's needed.

The makefile part shares some variables with current make and adds some
specific variables and includes. Ideally there's only one makefile but
I think that we can live with a separate makefile for android as there
seem to be specific quirks that would complicate the common makefile.

This means we'd have to keep the shared part in sync manually but it's
not that hard. New files or new libs, this always requires more care.

> And need some help on btrfs_wipe_existing_sb().\
> On the test it looks work well.\

The code changes should be hidden in wrappers and pulled via a separate
header file. If this is not possible, the ifdefs should be in the
function implementations (eg. is_ssd, check_overwrite), not at the call
sites.

Other than that, I don't mind adding support for android builds.  I don't
have an android build environment at hand and cannot verify that it's
always working, so the same holds as for musl libc, fixes are up to you.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to