On Wed, Oct 14, 2015 at 01:13:26AM +0900, Byongho Lee wrote:
> Below variables are defined per compress type.
> - struct list_head comp_idle_workspace[BTRFS_COMPRESS_TYPES]
> - spinlock_t comp_workspace_lock[BTRFS_COMPRESS_TYPES]
> - int comp_num_workspace[BTRFS_COMPRESS_TYPES]
> - atomic_t comp_alloc_workspace[BTRFS_COMPRESS_TYPES]
> - wait_queue_head_t comp_workspace_wait[BTRFS_COMPRESS_TYPES]
>
> BTW, while accessing one compress type of these variables, the next or
> before address is other compress types of it.
> So this patch puts these variables in a struct to make cache friendly.
Nice.
> +static struct {
> + struct list_head idle_workspace;
> + spinlock_t workspace_lock;
> + int num_workspace;
> + atomic_t alloc_workspace;
> + wait_queue_head_t workspace_wait;
> +} comp[BTRFS_COMPRESS_TYPES];
The name became too generic, please rename it to btrfs_comp_ws.
btrfs_comp_workspaces would be too long. I won't mind trimming the
members to 'ws' instead of 'workspace' so this does not result in too
wild code formatting. The use of the workspaces is localized only to the
compression code so it will not be confusing.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
