On Thu, Dec 10, 2015 at 11:16:27AM +0000, [email protected] wrote: > From: Filipe Manana <[email protected]> > > If we fail to allocate a new data chunk, we were jumping to the error path > without release the transaction handle we got before. Fix this by always > releasing it before doing the jump.
Looks good. Reviewed-by: Liu Bo <[email protected]> Thanks, -liubo > > Fixes: 2c9fe8355258 ("btrfs: Fix lost-data-profile caused by balance bg") > Signed-off-by: Filipe Manana <[email protected]> > --- > fs/btrfs/volumes.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c > index 3e55e07..f5e5e20 100644 > --- a/fs/btrfs/volumes.c > +++ b/fs/btrfs/volumes.c > @@ -3548,12 +3548,11 @@ again: > > ret = btrfs_force_chunk_alloc(trans, chunk_root, > BTRFS_BLOCK_GROUP_DATA); > + btrfs_end_transaction(trans, chunk_root); > if (ret < 0) { > mutex_unlock(&fs_info->delete_unused_bgs_mutex); > goto error; > } > - > - btrfs_end_transaction(trans, chunk_root); > chunk_reserved = 1; > } > > -- > 2.1.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
