On Mon, Feb 15, 2016 at 05:47:46PM +0100, David Sterba wrote:
> > + struct btrfs_super_block *disk_super = NULL;
>
> disk_super is NULL here and unchanged until ...
>
> > + if (!disk_super) {
>
> ... here, so this will always take this branch
>
> > + ret = btrfs_get_bdev_and_sb(device_path,
> > + FMODE_WRITE | FMODE_EXCL,
> > + root->fs_info->bdev_holder, 0,
> > + &bdev, &bh);
> > + if (ret) {
> > + /*
> > + * It could be a failed device ok for
> > clear_super
> > + * to fail. So return success
> > + */
> > + ret = 0;
> > + goto out;
> > + }
> > +
> > + disk_super = (struct btrfs_super_block *)bh->b_data;
> > + }
>
> The patch looks otherwise good so I'm curious if this is a leftover or
> I'm missing some logic behind that.
Never mind, the code gets removed anyway. Bisectability is not broken.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
