On Fri, Feb 26, 2016 at 10:41:31AM +0500, Roman Mamedov wrote: > On Wed, 6 Jan 2016 19:00:17 +0800 > Zhao Lei <zhao...@cn.fujitsu.com> wrote: > > > btrfs failed in xfstests btrfs/080 with -o nodatacow. > > > > Can be reproduced by following script: > > DEV=/dev/vdg > > MNT=/mnt/tmp > > > > umount $DEV &>/dev/null > > mkfs.btrfs -f $DEV > > mount -o nodatacow $DEV $MNT > > > > dd if=/dev/zero of=$MNT/test bs=1 count=2048 & > > btrfs subvolume snapshot -r $MNT $MNT/test_snap & > > wait > > -- > > We can see dd failed on NO_SPACE. > > > > Reason: > > __btrfs_buffered_write should run cow write when no_cow impossible, > > and current code is designed with above logic. > > But check_can_nocow() have 2 type of return value(0 and <0) on > > can_not_no_cow, and current code only continue write on first case, > > the second case happened in doing subvolume. > > > > Fix: > > Continue write when check_can_nocow() return 0 and <0. > > > > Signed-off-by: Zhao Lei <zhao...@cn.fujitsu.com> > > Guys please don't forget about this patch. It solves real problem for people, > http://www.spinics.net/lists/linux-btrfs/msg51276.html > http://www.spinics.net/lists/linux-btrfs/msg51819.html > but it's not in 4.4.1, not in 4.4.2... and now not in 4.4.3
Dave already has it queued for the next merge window. Thanks! -chris -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
