On Mon, Feb 29, 2016 at 10:04:35AM +0800, Qu Wenruo wrote: > Hi Dave, > > Thanks for the review. > > All comment are correct and I'll update the patchset soon. > > Only one small question below > > Dave Chinner wrote on 2016/02/29 09:26 +1100: > ... > >>+# File size is twice the maximum file extent of btrfs > >>+# So even fallbacked to non-dedup, it will have at least 2 extents > >>+file_size=$(( 256 * 1024 * 1024 )) > > > >Used for xfs_io, so "file_size=256m" is all that is needed here. > > Super nice feature for support unit suffix, I checked man page of > xfs_io but only value for extsize mentioned the support for such > suffix. > > I assume all offset/length/bsize/value support suffix, right?
Yes, they do, always have, originally came from other XFS commands (i.e see the mkfs.xfs for the "usual units suffixes" description). > Hope man page get updated. Can you send a patch? Cheers, Dave. -- Dave Chinner [email protected] -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
