On Tue, Oct 11, 2016 at 10:18:51AM +0800, Qu Wenruo wrote:
> >> -/* Caller should ensure sizeof(*ret) >= 29 "NODATASUM|NODATACOW|READONLY" 
> >> */
> >> +#define copy_one_inode_flag(flags, name, empty, dst) ({                   
> >> \
> >> +  if (flags & BTRFS_INODE_##name) {                               \
> >> +          if (!empty)                                             \
> >> +                  strcat(dst, "|");                               \
> >> +          strcat(dst, #name);                                     \
> >> +          empty = 0;                                              \
> >> +  }                                                               \
> >> +})
> >
> > Can you please avoid using the macro? Or at least make it uppercase so
> > it's visible. Similar in the next patch.
> >
> >
> OK, I'll change it to upper case.

Ok.

> The only reason I'm using macro is, inline function can't do 
> stringification, or I missed something?

No, that's where macros help. My concern was about the hidden use of a
local variable, so at least an all-caps macro name would make it more
visible. As this is not going to be used elsewhere, we can live with
that.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to