On Wed, Jan 18, 2017 at 09:42:45PM -0600, Goldwyn Rodrigues wrote: > >>> +#define BUG_ON(c) ASSERT(!(c)) > >> > >> The problem with this is that you are killing the value printed as a > >> part of the trace for BUG_ON(). The main reason why commit > >> 00e769d04c2c83029d6c71 was written. Please be careful with your notting > >> especially when the values are being printed. > >> > > > > This is designed. > > > > As ASSERT() is more meaningful than the abused BUG_ON(), I changed it to > > print correct value for ASSERT() and ignore BUG_ON(). > > If ASSERT is meaningful, correct it. But please don't make BUG_ON worse > and leave it as it is, at least until the time you can remove the > BUG_ONs or convert it. It should print the correct value of why it did > bug, or else it will print just 1, which is of no debug value.
Agreed, we want to see the exact value. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
