Omar, On Wed, Jan 25, 2017 at 3:38 AM, Omar Sandoval <[email protected]> wrote: > From: Omar Sandoval <[email protected]> > > When you snapshot a subvolume containing a subvolume, you get a > placeholder read-only directory where the subvolume would be. These > directory inodes have ->i_ops set to btrfs_dir_ro_inode_operations. > Previously, this didn't include the xattr operation callbacks. The > conversion to xattr_handlers missed this case, leading to bogus attempts > to set xattrs on these inodes. This manifested itself as failures when > running delayed inodes. > > To fix this, clear the IOP_XATTR in ->i_opflags on these inodes. > > Fixes: 6c6ef9f26e59 ("xattr: Stop calling {get,set,remove}xattr inode > operations") > Cc: Andreas Gruenbacher <[email protected]> > Reported-by: Chris Murphy <[email protected]> > Signed-off-by: Omar Sandoval <[email protected]> > --- > Applies to v4.10-rc4. Chris, this fixes the issue for me, could you please > test > it out? Andreas, does this make sense? I'll try to cook up an xfstest for > this.
this change looks good. Are those directories really read-only though? They have the S_IWUSR permission set, and an update_time iop. Also, the get_acl and set_acl iops seem dead: they were not called before because the xattr iops were not defined in btrfs_dir_ro_inode_operations, and they are not called now because IOP_XATTR is cleared. Could you please check that as well? Thanks, Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
