On Mon, Apr 17, 2017 at 11:26:33AM +0800, Qu Wenruo wrote: > Introduce a new command, btrfs-modify, which is not part of 'btrfs', but > an independent command, bring minimal impact to existing btrfs commands. > > Btrfs-modify is designed to provides better documentation than current > btrfs-corrupt-block with better subcommand division to reduce confusing > or conflicting options. > > Btrfs-modify paired with offline-scrub patchset (not merged yet) could > provide a full suite for test case writers to do corruption and recovery > verification.
Starting a new tool makes sense, the btrfs-corrupt-block lacks the subcommand hierarchy and it would be tedious to sew it in. The commands that you add now still seem ad-hoc, adressing current needs. This is how the corrupt-block utility started as well. I'd like see some proposal of more potential uses and some command gouping. For example main group: set, get, map, delete, insert, show. Then, define for which objects the commands are applicable. We can start with the raid56 testing usecase. You want to locate and modify a block baced on the logical offset, so this should comprise of 'map' + 'set'. For specific tasks we can add shortcuts or compound commands, not from the start. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
