Please add subsystem prefixes to your subject lines, e.g.

fs:

for all the generic fs ones,

xfs:

for XFS,

block:

for block layer changes, etc.

>  
> -     if (flags & ~(RWF_HIPRI | RWF_DSYNC | RWF_SYNC))
> -             return -EOPNOTSUPP;
> -
>       init_sync_kiocb(&kiocb, filp);
> -     if (flags & RWF_HIPRI)
> -             kiocb.ki_flags |= IOCB_HIPRI;
> -     if (flags & RWF_DSYNC)
> -             kiocb.ki_flags |= IOCB_DSYNC;
> -     if (flags & RWF_SYNC)
> -             kiocb.ki_flags |= (IOCB_DSYNC | IOCB_SYNC);
> +     ret = kiocb_set_rw_flags(&kiocb, flags);
> +     if (ret)
> +             return ret;

And please split factoring out kiocb_set_rw_flags into a separate
prep patch.

Otherwise these changes look fine:

Reviewed-by: Christoph Hellwig <h...@lst.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to