On Fri, May 19, 2017 at 05:47:48PM -0700, Marc MERLIN wrote: > On Sat, May 20, 2017 at 12:37:47AM +0000, Hugo Mills wrote: > > > Can I make another plea for just removing all those BUG/BUG_ON? > > > They really have no place in production code, there is no excuse for a > > > filesystem to bring down the entire and in the process not even tell you > > > which of your filesystems had the issue to start with. > > > > > > Could this be made part of a cleanup for this build to remove them all? > > > > The removal of these has been an ongoing process for at least the > > last 5 years. > > That's great news, thanks. I guess I'm a bit edgy because I've hit too many > of them already :) but glad to hear that there are a lot fewer now. > > > I don't understand the specifics of the kernel code in question(*), > > but compared to 5 years ago, btrfs has got rid of most of the > > BUG_ONs(**) a few years ago. The remaining ones are probably > > complicated to deal with in any way more elegant than just stopping. > > The biggest problem is that those BUG* do not even tell you where the > problem. > The assumption that you'd only ever have a single btrfs filesystem mounted, > is flawed to say the least :) > (I have 5 different ones on my server)
I think from the POV of removing these BUG_ONs, it doesn't matter which FS causes them. "All" you need to know is where the error happened. From there, you can (in theory) work out what was wrong and handle it more elagantly than simply stopping. Obviously it would be nice, from the POV of the sysadmin, to know which FS was complaining, but as an FS developer it's secondary to identifying a BUG_ON which happens in real life, which offers an opportunity to make the error path more elegant. > > I recall seeing someone's stats on BUG_ON locations a couple of > > years ago, and btrfs had managed to get the number of locations down > > below XFS (but no other FS). It's a kind of success, at least... > > Good to know, thanks, and thanks to anyone who has worked on removing those. I don't know what the current state is. Maybe someone on IRC will be able to do the greps/stats to give proper numbers to it. Hugo. -- Hugo Mills | IMPROVE YOUR ORGANISMS!! hugo@... carfax.org.uk | http://carfax.org.uk/ | PGP: E2AB1DE4 | Subject line of spam email
signature.asc
Description: Digital signature
