On Thu, May 25, 2017 at 06:39:52AM -0400, Jeff Layton wrote: > Nothing checks its return value.
I think we don't need to check the return value of filemap_fdatawait_range, because the errors are tracked by other means (attached to the btree_inode mapping that represents the metadata), in set_btree_ioerr. > Signed-off-by: Jeff Layton <jlay...@redhat.com> > Reviewed-by: Jan Kara <j...@suse.cz> > Reviewed-by: Liu Bo <bo.li....@oracle.com> To Liu Bo: May I ask if you did a review that matches the above understanding? It's trivial to see that nothing really checks the return value of btrfs_wait_tree_block_writeback but my question is if it's really safe not to so. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html