On Mon, May 15, 2017 at 02:06:54PM +0530, Lakshmipathi.G wrote:
> On Mon, May 15, 2017 at 09:40:29AM +0800, Qu Wenruo wrote:
> > >bug: https://bugzilla.kernel.org/show_bug.cgi?id=194795
> > 
> > Errr, it seems that you forgot to update ext2_open_fs() to update how we get
> > cctx->block_counts.
> > 
> > Without that update, we still get wrong total size of original fs, so
> > converted image will be corrupted.
> > 
> > In this 22T case, it can't pass convert test since after conversion,
> > converted image can't pass e2fsck.
> > 
> > Thanks,
> > Qu
> > 
> 
> Thanks for pointing out the issue. So we need to update 
> common.h/cctx->block_count from u32 to u64?

I think we should use the 64bit types just to be safe.

> do we also need to change other fields like inodes_count and
> free_inode_count?

Yes please.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to