On 5.12.2017 19:50, David Sterba wrote:
> On Tue, Dec 05, 2017 at 04:10:59PM +0800, Qu Wenruo wrote:
>>
>>
>> On 2017年12月05日 15:29, Nikolay Borisov wrote:
>>> This function was introduced by 247e743cbe6e ("Btrfs: Use async helpers to
>>> deal
>>> with pages that have been improperly dirtied") and it didn't do any error
>>> handling then. This function might very well fail in ENOMEM situation, yet
>>> it's not handled, this could lead to inconsistent state. So let's handle the
>>> failure by setting the mapping error bit.
>>>
>>> Signed-off-by: Nikolay Borisov <nbori...@suse.com>
>>> Cc: sta...@vger.kernel.org
>>
>> Reviewed-by: Qu Wenruo <w...@suse.com>
>>
>> That's the only missing one. Nice catch.
>
> You mean the only unhandled call of btrfs_set_extent_delalloc? There's
> one more in relocate_file_extent_cluster.
I'd prefer this call site be handled in a separate patch.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
