On Sat, Feb 03, 2018 at 09:07:47AM +0000, Gu, Jinxiang wrote: > > > > -----Original Message----- > > From: David Sterba [mailto:dste...@suse.cz] > > Sent: Saturday, February 03, 2018 2:08 AM > > To: Gu, Jinxiang/顾 金香 <g...@cn.fujitsu.com> > > Cc: linux-btrfs@vger.kernel.org; dste...@suse.cz; quwenruo.bt...@gmx.com > > Subject: Re: [RFC PATCH v2 2/4] btrfs-progs: Add EXEC represent path of > > executable file > > > > On Fri, Feb 02, 2018 at 04:34:03PM +0800, Gu Jinxiang wrote: > > > Use EXEC instead of TOP to represent the path of excutable file. > > > EXEC is set to TOP by default, but when there is no excutable file in > > > TOP, use the path where btrfs is install as EXEC. > > > > What if we just allow to change TOP (ie. do not overwrite it in the test > > driver scripts)? The logic will be the same as with EXEC, but we won't > > have to rewrite essentailly all paths in the testsuite. > > > Since besides executable files, TOP is also used to find > $TOP/tests/common, $TOP/Documentation, $TOP/tests/fuzz-tests/images, > i.e. > so, change TOP will also effect on those resources.
Yeah $TOP is used for too many different things. It works for from inside git, but this needs to change for the exported testsuite. So TEST_TOP for the sourced 'common' scripts and maybe other variables for the internal binaries that do not get typically installed. > So, I introduce EXEC to differentiate executable files and other resources. I understand why but I don't like this approach. TOP should be enough for all binaries that are expected to exist in the path, the rest needs own variable. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
