On Thu, Feb 22, 2018 at 06:12:14PM +0200, Nikolay Borisov wrote: > Now that the read side is extracted into its own function, do the same > to the write side. This leaves btrfs_get_blocks_direct_write with the > sole purpose of handling common locking required. Also flip the > condition in btrfs_get_blocks_direct_write so that the write case > comes first and we check for if (Create) rather than if (!create). This > is purely subjective but I believe makes reading a bit more "linear".
I subjectively agree. > No functional changes. > > Signed-off-by: Nikolay Borisov <nbori...@suse.com> Reviewed-by: David Sterba <dste...@suse.com> Same comment as before, no __ and please use the single-return exit block where possible. > Both patches survived xfstests runs. I'll add that to misc-next, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html