On Wed, Apr 11, 2018 at 03:29:35PM +0800, Qu Wenruo wrote: > The old flag OPEN_CTREE_FS_PARTIAL is in fact quite easy to be confused > with OPEN_CTREE_PARTIAL, which allow btrfs-progs to open damaged > filesystem (like corrupted extent/csum tree). > > However OPEN_CTREE_FS_PARTIAL, unlike its name, is just allowing > btrfs-progs to open fs with temporary superblocks (which only has 6 > basic trees on SINGLE meta/sys chunks). > > The usage of FS_PARTIAL is really confusing here. > > So rename OPEN_CTREE_FS_PARTIAL to OPEN_CTREE_TEMPORARY_SUPER, and add > extra comment for its behavior. > Also rename BTRFS_MAGIC_PARTIAL to BTRFS_MAGIC_TEMPORARY to keep the > naming consistent. > > And with above comment, the usage of FS_PARTIAL in dump-tree is > obviously incorrect, fix it. > > Fixes: 8698a2b9ba89 ("btrfs-progs: Allow inspect dump-tree to show specified > tree block even some tree roots are corrupted") > Signed-off-by: Qu Wenruo <w...@suse.com>
Applied, thanks. I got a few compilation errors where BTRFS_MAGIC_PARTIAL was not updated, but that's trivial to fix. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html